Bugfix for memory leak #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
  This PR updates the comments for `StreamableServerTransport.streamRequests` to correct typos and improve clarity.
…ol#89) The version is 1.25, which doesn't match the main module's go.mod.
…elcontextprotocol#91) The text field is required, but current implementation omits the text field when it is a blank string. Some clients fail to parse the response if the text field is omitted. A blank text result is a valid MCP response. Claude desktop error message: ``` ClaudeAiToolResultRequest.content.0.text.text: Field required ``` The solution is to return the field even when it is blank by removing `omitempty`.
…tprotocol#96) I noticed this while working on modelcontextprotocol#95. Seems Meta was accidentally skipped in the custom wire format struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Tips
Typically, PRs should consist of a single commit, and so should generally follow
the rules for Go commit messages, with the following
changes and additions:
Markdown is allowed.
For a pervasive change, use "all" in the title instead of a package name.
The PR description should provide context (why this change?) and describe the changes
at a high level. Changes that are obvious from the diffs don't need to be mentioned.